Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: handle cook version (pass1 vs. pass2) #52

Merged
merged 4 commits into from
Oct 22, 2024
Merged

feat!: handle cook version (pass1 vs. pass2) #52

merged 4 commits into from
Oct 22, 2024

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Sep 28, 2024 •
edited
Loading

This is a breaking change, such that the QADB constructor now requires a string argument to specify the cook version:

      //   - 'latest': just use the latest available one
      //   - 'pass1': use pass 1
      //   - 'pass2': use pass 2

The required argument helps ensure that analyzers are aware of the change, namely those who are analyzing older datasets.

@c-dilks c-dilks marked this pull request as ready for review October 22, 2024 14:56
@c-dilks c-dilks enabled auto-merge (squash) October 22, 2024 15:25
@c-dilks c-dilks merged commit d165bc7 into main Oct 22, 2024
12 checks passed
@c-dilks c-dilks deleted the handle-pass2 branch October 22, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@c-dilks